WIP: Revised Dockerfile. #2

Closed
jtorre wants to merge 1 commits from jtorre/broccoli-cli:develop into develop
Member

This Dockerfile addresses issue #1 (comment).

The user and token secrets generated to clone waveview are local to my machine; I am not certain how to parametrize these for building elsewhere, or if changes in the README should be made to guide the end-user in creating their own.

This Dockerfile addresses issue https://git.broccolimicro.io/Broccoli/broccoli-cli/issues/1#issue-2. The user and token secrets generated to clone waveview are local to my machine; I am not certain how to parametrize these for building elsewhere, or if changes in the README should be made to guide the end-user in creating their own.
jtorre added 1 commit 2023-05-14 15:16:40 -04:00

It looks like some references to your specific clones of act or actsim have been added to the dockerfile rather than the centralized ones. We probably want to keep those references centralized. Otherwise, it looks good

It looks like some references to your specific clones of act or actsim have been added to the dockerfile rather than the centralized ones. We probably want to keep those references centralized. Otherwise, it looks good
edward.bingham approved these changes 2023-05-15 13:34:05 -04:00
Author
Member

It is possible that

f8340379df/configure

It is possible that https://github.com/asyncvlsi/act/blob/f8340379dfe4b2410d74338aa070c67eb5ade021/configure
jtorre closed this pull request 2023-05-18 01:35:45 -04:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Broccoli/broccoli-cli#2
No description provided.